[webkit-reviews] review denied: [Bug 47518] Add DelayDSPKernel files : [Attachment 70495] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Chris Rogers
<crogers at google.com>'s request for review:
Bug 47518: Add DelayDSPKernel files
https://bugs.webkit.org/show_bug.cgi?id=47518

Attachment 70495: Patch
https://bugs.webkit.org/attachment.cgi?id=70495&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70495&action=review

> WebCore/webaudio/DelayDSPKernel.cpp:43
> +    , m_buffer(static_cast<size_t>(processor->sampleRate() *
DefaultMaxDelayTime))

do you need to worry about the case where someone calls DelayDSPKernel(0)

> WebCore/webaudio/DelayDSPKernel.h:46
> +    void setDelayFrames(double numberOfFrames);

this implementation looks like it should be in the header (it's one line in the
cpp file)

> WebCore/webaudio/DelayDSPKernel.h:48
> +protected:

why protected and not private