[webkit-reviews] review denied: [Bug 47517] Add DelayProcessor files : [Attachment 70494] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Chris Rogers
<crogers at google.com>'s request for review:
Bug 47517: Add DelayProcessor files
https://bugs.webkit.org/show_bug.cgi?id=47517

Attachment 70494: Patch
https://bugs.webkit.org/attachment.cgi?id=70494&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70494&action=review

> WebCore/webaudio/DelayProcessor.h:34
> +namespace WebCore {

don't you want an #if ENABLE(WEB_AUDIO) in the header file too?

> WebCore/webaudio/DelayProcessor.h:45
> +    AudioParam* delayTime() { return m_delayTime.get(); }

this should be const

> WebCore/webaudio/DelayProcessor.h:48
> +    RefPtr<AudioParam> m_delayTime;

why this is protected instead of private