[webkit-reviews] review denied: [Bug 37261] White space preceding a <br> affects layout of center or right aligned preceding line : [Attachment 62149] Updated patch containing only the changed code and added test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 10 11:45:32 PDT 2010


Adam Barth <abarth at webkit.org> has denied Xianzhu Wang <phnixwxz at gmail.com>'s
request for review:
Bug 37261: White space preceding a <br> affects layout of center or right
aligned preceding line
https://bugs.webkit.org/show_bug.cgi?id=37261

Attachment 62149: Updated patch containing only the changed code and added test
case
https://bugs.webkit.org/attachment.cgi?id=62149&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I looked at the example sites you reference above.  I couldn't really see any
difference in the rendering around the text that you cited between WebKit and
Firefox.  This seems to be a very minor issue.	I'm not sure the risks of
taking these patches are worth the potential upside.  However, I'll defer to
the rendering experts if they have a different opinion.

Rather than have these patches sit in pending-review, I'm making them R-.  If a
reviewer is interested in moving this bug forward, please feel free to review
them.


More information about the webkit-reviews mailing list