[webkit-reviews] review denied: [Bug 42639] Moves various exception code offsets to a central place. : [Attachment 62085] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Marcus Bulach <bulach at chromium.org>'s
request for review:
Bug 42639: Moves various exception code offsets to a central place.
https://bugs.webkit.org/show_bug.cgi?id=42639

Attachment 62085: Patch
https://bugs.webkit.org/attachment.cgi?id=62085&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=62085&action=review

I'm not sure why we want to make this change.  I like the idea of making
ExceptionCode into a struct that has an int member.  That would seem to make it
much easier to use the C++ type system to help us with correctness.

> WebCore/dom/ExceptionOffset.h:38
> +	   EVENT_EXCEPTION_OFFSET = 100,
> +	   EVENT_EXCEPTION_MAX = 199,
> +	   RANGE_EXCEPTION_OFFSET = 200,
> +	   RANGE_EXCEPTION_MAX = 299,
> +	   XML_HTTP_REQUEST_EXCEPTION_OFFSET = 500,
> +	   XML_HTTP_REQUEST_EXCEPTION_MAX = 699,

I'm not sure these are named correctly.  Do we use ALL_CAPS names for similar
things?