[webkit-reviews] review granted: [Bug 47357] Make findNextLineBreak writing-mode-aware. : [Attachment 70099] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 47357: Make findNextLineBreak writing-mode-aware.
https://bugs.webkit.org/show_bug.cgi?id=47357

Attachment 70099: Patch
https://bugs.webkit.org/attachment.cgi?id=70099&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=70099&action=review

> WebCore/rendering/RenderBlockLineLayout.cpp:1594
> +		       tmpW +=	replacedLogicalWidth;

extra space there

> WebCore/rendering/RenderBoxModelObject.h:102
> +    bool hasInlineDirectionBordersPaddingOrMargin() const { return
hasInlineDirectionBordersOrPadding() || marginStart() != 0 || marginEnd() != 0;
}
> +    bool hasInlineDirectionBordersOrPadding() const { return borderStart()
!= 0 || borderEnd() != 0 || paddingStart() != 0 || paddingEnd() != 0; }

You should drop the “!= 0”s per our style.