[webkit-reviews] review requested: [Bug 47345] [Qt] Implement SharedMemory for WebKit2 : [Attachment 70100] updated proposed patch

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 47345: [Qt] Implement SharedMemory for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=47345

Attachment 70100: updated proposed patch
https://bugs.webkit.org/attachment.cgi?id=70100&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
(In reply to comment #4)
> There is no need to allocating a MappedMemory for storing the result. You
should do it like 'current = &pool->at(n)'

It's true. Done.

> You have almost the same for in mapFile and mapMemory. All of these should be
merged to a static that returns
> with a pointer and you can do what you want to do with the pointer at the
caller site.

Unfortunately, we can't merge them, these needs to do different things.
 
> Here you should check for 0 pointer or asserting that the result is not zero.
I think it should be never be zero here.

I added a null check.