[webkit-reviews] review denied: [Bug 47246] Improve ellipse path generation : [Attachment 70042] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Shane Stephens
<shanestephens at google.com>'s request for review:
Bug 47246: Improve ellipse path generation
https://bugs.webkit.org/show_bug.cgi?id=47246

Attachment 70042: Patch
https://bugs.webkit.org/attachment.cgi?id=70042&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70042&action=review

The algorithm looks good. But I guess you have to take git-svn or something
like that to create patches that can be handled by the bots.

You also did not answer the question. Did you update to the latest results?
Does this really not change pixel tests?

> WebCore/platform/graphics/Path.cpp:39
>  static const float QUARTER = 0.552f; // approximation of control point
positions on a bezier
>				 // to simulate a quarter of a circle.

When you are on it, can you rename QUARTER please? Should match the naming
schema of consts (Beginning with a g). Quarter is not really meaningful. Maybe
you find a better name. And align the comments please

> WebCore/platform/graphics/Path.cpp:42
> +// number of path segments used to approximate circles and ellipses.
> +static const unsigned gEllipseFragments = 100;

Not sure if we need the comment at all. The name says all.