[webkit-reviews] review granted: [Bug 47053] Rename (and move) RenderPath to svg/RenderSVGPath : [Attachment 70036] Proposed patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 7 00:11:22 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 47053: Rename (and move) RenderPath to svg/RenderSVGPath
https://bugs.webkit.org/show_bug.cgi?id=47053

Attachment 70036: Proposed patch v4
https://bugs.webkit.org/attachment.cgi?id=70036&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70036&action=review

> WebCore/WebCore.vcproj/WebCore.vcproj:33063
> +				       
RelativePath="..\rendering\svg\RenderSVGPath.cpp"

This is problematic, you're now excluding this file from the build.
If you do that, you have to add RenderSVGPath to
rendering/RenderSVGAllInOne.cpp.
But as we didn't do that before, I'd say revert the FileConfiguration part.

r=me, if you fix that before landing, otherwhise win is broken.


More information about the webkit-reviews mailing list