[webkit-reviews] review granted: [Bug 47105] [Qt] Hook up accelerometer data via Qt DeviceMotion : [Attachment 69974] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 6 22:35:05 PDT 2010
Andreas Kling <kling at webkit.org> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 47105: [Qt] Hook up accelerometer data via Qt DeviceMotion
https://bugs.webkit.org/show_bug.cgi?id=47105
Attachment 69974: Patch v2
https://bugs.webkit.org/attachment.cgi?id=69974&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69974&action=review
r=me, but please fix the below:
> WebKit/qt/WebCoreSupport/DeviceMotionProviderQt.h:44
> + DeviceMotionData* currentDeviceMotion() { return m_motion.get(); }
This method should be const.
More information about the webkit-reviews
mailing list