[webkit-reviews] review granted: [Bug 47319] rebaseline-chromium-webkit-tests asserts when generating the html report : [Attachment 70027] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 47319: rebaseline-chromium-webkit-tests asserts when generating the html
report
https://bugs.webkit.org/show_bug.cgi?id=47319

Attachment 70027: Patch
https://bugs.webkit.org/attachment.cgi?id=70027&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70027&action=review

> WebKitTools/Scripts/webkitpy/common/system/path.py:1
> +#!/usr/bin/env python

We don't need these lines at the top of files.

> WebKitTools/Scripts/webkitpy/common/system/path.py:48
> +    return "file:///" + path.replace("\\", "/")

Do we need to do any URL escaping?  This feels like too many ///.  Do we want
file://c:/foo
or
file:///c:/foo
?

> WebKitTools/Scripts/webkitpy/common/system/path_unittest.py:34
> +class AbspathTest(unittest.TestCase):

Can you add some tests with %, space, +, and $ ?

>
WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:6
55
> +	   return webkitpy.common.system.path.abspath_to_uri(path,
self._executive)

Crazy.	I'd rather import this at the top of the file.	That makes it easier to
grep the codebase and understand what's going on.