[webkit-reviews] review granted: [Bug 47282] [CHROMIUM] Crash on failed shader compilation. : [Attachment 69962] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 11:13:16 PDT 2010


James Robinson <jamesr at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 47282: [CHROMIUM] Crash on failed shader compilation.
https://bugs.webkit.org/show_bug.cgi?id=47282

Attachment 69962: Patch
https://bugs.webkit.org/attachment.cgi?id=69962&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69962&action=review

Good catch.

> WebCore/platform/graphics/gpu/SharedGraphicsContext3D.h:122
> +    SharedGraphicsContext3D(PassOwnPtr<GraphicsContext3D> context,
PassOwnPtr<SolidFillShader> solidFillShader, PassOwnPtr<TexShader> texShader);

nit: don't need to name the params here


More information about the webkit-reviews mailing list