[webkit-reviews] review denied: [Bug 47278] Add WebThemeEngine api for chromium/linux : [Attachment 69960] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 6 11:12:49 PDT 2010
Tony Chang <tony at chromium.org> has denied Dave Moore <davemoore at google.com>'s
request for review:
Bug 47278: Add WebThemeEngine api for chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=47278
Attachment 69960: Patch
https://bugs.webkit.org/attachment.cgi?id=69960&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69960&action=review
Can you also update WebKit.gyp to include the new files (maybe remove the old
file?) and update WebKit/chromium/src/ChromiumBridge.cpp to include
win/WebThemeEngine.h?
> ChangeLog:11
> + * ../../WebKit/chromium/public/WebThemeEngine.h:
This path is incorrect. Maybe webkit-patch is confused about being an svn
checkout in a chromium git checkout? This path should be relative to the
ChangeLog file.
More information about the webkit-reviews
mailing list