[webkit-reviews] review requested: [Bug 46775] getBoundingClientRect does not work with SVG <text> : [Attachment 69813] Fix, layout test and code cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 5 11:13:15 PDT 2010


Cosmin Truta <ctruta at chromium.org> has asked  for review:
Bug 46775: getBoundingClientRect does not work with SVG <text>
https://bugs.webkit.org/show_bug.cgi?id=46775

Attachment 69813: Fix, layout test and code cleanup
https://bugs.webkit.org/attachment.cgi?id=69813&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
I am submitting the straightforward solution, checking for isText in addition
to isStyledLocatable.

If you want me to make SVGTextElement a subclass of SVGStyledLocatable, please
let me know, and I will try implementing this new design this in a separate
patch.

Also, if you want me to fix SVGLocatable::getTransformToElement by accounting
for SVGTextElement in addition to SVGStyledLocatableElement when calling
getCTM, please tell me, and I'll open a separate bug where I will fix it.


More information about the webkit-reviews mailing list