[webkit-reviews] review denied: [Bug 47197] Fix ownership of GraphicsContext3D in SharedGraphicsContext3D to prevent early deallocation and crash : [Attachment 69812] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 47197: Fix ownership of GraphicsContext3D in SharedGraphicsContext3D to
prevent early deallocation and crash
https://bugs.webkit.org/show_bug.cgi?id=47197

Attachment 69812: Patch
https://bugs.webkit.org/attachment.cgi?id=69812&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69812&action=review

> WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:59
> -    OwnPtr<GraphicsContext3D> context = GraphicsContext3D::create(attr,
hostWindow);
> +    PassOwnPtr<GraphicsContext3D> context = GraphicsContext3D::create(attr,
hostWindow);
>      if (!context)
>	   return 0;
> -    return adoptRef(new SharedGraphicsContext3D(context.get()));
> +    return adoptRef(new SharedGraphicsContext3D(context));
>  }

It would be better to keep the context variable an OwnPtr, and pass
context.release() to SharedGraphicsContext3D.

Is it possible to make a test?