[webkit-reviews] review granted: [Bug 37812] Assertion failure when appcache/fail-on-update.html is run twice in a row : [Attachment 69709] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 4 16:06:21 PDT 2010


Adam Barth <abarth at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 37812: Assertion failure when appcache/fail-on-update.html is run twice in
a row
https://bugs.webkit.org/show_bug.cgi?id=37812

Attachment 69709: proposed fix
https://bugs.webkit.org/attachment.cgi?id=69709&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69709&action=review

Hum...	This change is a bit mysterious to me, but ap tells me that no one
really understands appcache and he's looking for more of a sanity check.

> LayoutTests/http/tests/appcache/resources/fail-on-update-2.php:4
> +$tmpFile = sys_get_temp_dir() . "/" . "fail_on_update_state";

Does sys_get_temp_dir give you something specific to webkit?


More information about the webkit-reviews mailing list