[webkit-reviews] review denied: [Bug 46527] Add BiquadProcessor files : [Attachment 69707] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 46527: Add BiquadProcessor files
https://bugs.webkit.org/show_bug.cgi?id=46527

Attachment 69707: Patch
https://bugs.webkit.org/attachment.cgi?id=69707&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69707&action=review

Thanks for addressing the earlier review feedback. One more issue.

> WebCore/webaudio/BiquadProcessor.cpp:51
> +    case HighPass2:

Since it sounds like these share the same coefficients and how the biquad
processor is set up (for a low-pass vs. high-pass filter) is handled at a lower
level, please fold these two switch arms together and consider adding a comment
that they share the same parameter values, only differing in type.