[webkit-reviews] review denied: [Bug 47053] Rename (and move) RenderPath to svg/RenderSVGPath : [Attachment 69580] Proposed patch v2

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Andreas Kling <kling at webkit.org>'s
request for review:
Bug 47053: Rename (and move) RenderPath to svg/RenderSVGPath
https://bugs.webkit.org/show_bug.cgi?id=47053

Attachment 69580: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=69580&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69580&action=review

You can either land this patch together with your next patches or update the
19MB :-) r- for the wrong moving of the files + s/isVGPath/isRenderSVGPath/

> WebCore/ChangeLog:8
> +	   Also renamed RenderObject::isRenderPath() to isSVGPath()

isRenderSVGPath(), should really be similar to the name of the renderer.

> WebCore/ChangeLog:22
> +	   * rendering/RenderPath.cpp: Removed.
> +	   * rendering/RenderPath.h: Removed.
> +	   * rendering/RenderSVGHiddenContainer.cpp:

Please use 'svn mv' to move the files instead of copying. That is better for
traversing  the history.