[webkit-reviews] review granted: [Bug 47052] [Qt] Hook up DeviceOrientation data for Qt support : [Attachment 69581] Patch v2

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 47052: [Qt] Hook up DeviceOrientation data for Qt support
https://bugs.webkit.org/show_bug.cgi?id=47052

Attachment 69581: Patch v2
https://bugs.webkit.org/attachment.cgi?id=69581&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69581&action=review

r+ if you fix the RefPtr issue.

> WebCore/WebCore.pro:@
>  contains(DEFINES, ENABLE_DEVICE_ORIENTATION=1) {

This is disabled by default? Would be nice to have enabled on the buildbots

>> WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.h:51
>> +	PassRefPtr<DeviceOrientation> m_orientation;
> 
> This should be a RefPtr.

This will need to be fixed before landing!