[webkit-reviews] review granted: [Bug 46947] texImage2D fails on 16-bit-per-channel images : [Attachment 69409] revised patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 46947: texImage2D fails on 16-bit-per-channel images
https://bugs.webkit.org/show_bug.cgi?id=46947

Attachment 69409: revised patch
https://bugs.webkit.org/attachment.cgi?id=69409&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69409&action=review

Looks OK. I think we should try to figure out a different structure (like a
table) for the large switch statements in GraphicsContext3D::getImageData
because they're really getting out of hand. Please consider filing a follow-up
bug to rethink the structure there. One minor comment-related comment.

> WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp:131
>	   // This path is only accessible for MacOS earlier than 10.6.4.

Is this comment still accurate?