[webkit-reviews] review granted: [Bug 47022] Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it : [Attachment 69527] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 47022: Add proxy server query function proxyServersForURL and change the
Mac plug-in code to use it
https://bugs.webkit.org/show_bug.cgi?id=47022

Attachment 69527: Patch
https://bugs.webkit.org/attachment.cgi?id=69527&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=69527&action=review

> WebCore/WebCore.xcodeproj/project.pbxproj:16513
> -			name = cf;
> +			path = cf;

Weird.

> WebCore/platform/network/ProxyServer.cpp:55
> +    builder.append(' ');

Is the trailing space is required by
<http://web.archive.org/web/20060424005037/wp.netscape.com/eng/mozilla/2.0/reln
otes/demo/proxy-live.html>?

> WebCore/platform/network/ProxyServer.cpp:65
> +	   if (i != 0)

No “!= 0” needed

> WebCore/platform/network/cf/ProxyServerCFNet.cpp:34
> +#if defined(BUILDING_ON_TIGER) || defined(BUILDING_ON_LEOPARD)

Can you put the special-case code after the normal case code?

> WebKit/ChangeLog:10
> +2010-10-01  Anders Carlsson	<andersca at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add proxy server query function proxyServersForURL and change the
Mac plug-in code to use it
> +	   https://bugs.webkit.org/show_bug.cgi?id=47022
> +	   <rdar://problem/8504712>
> +
> +	   * WebKit.xcodeproj/project.pbxproj:
> +

Please don’t check this in.

> WebKit/WebKit.xcodeproj/project.pbxproj:1677
> +			developmentRegion = English;

Ditto.