[webkit-reviews] review granted: [Bug 48516] GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument : [Attachment 75150] Proposed patch v6

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 48516: GraphicsContext: Remove "current path" and have strokePath, fillPath
and clipPath take a Path argument
https://bugs.webkit.org/show_bug.cgi?id=48516

Attachment 75150: Proposed patch v6
https://bugs.webkit.org/attachment.cgi?id=75150&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75150&action=review

Looks great! Don't think that it needs another round. But would be great if you
can fix the following snippets. r=me.

> WebCore/ChangeLog:5
> +	   GraphicsContext: Remove "current path" and have strokePath, fillPath
and clipPath take a Path argument.

I sometime make mistakes with english phrasing. Not sure, but have ... take
sounds strange :-P

> WebCore/platform/graphics/cg/GraphicsContextCG.cpp:@
>  void GraphicsContext::drawConvexPolygon(size_t npoints, const FloatPoint*
points

Don't like the name npoints. Can you rename it to numPoints like in
addConvexPolygonToPath? Or rename both to numberOfPoints?