[webkit-reviews] review granted: [Bug 50207] Rebaseline server: baseline display tweaks : [Attachment 75102] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 50207: Rebaseline server: baseline display tweaks
https://bugs.webkit.org/show_bug.cgi?id=50207

Attachment 75102: Patch
https://bugs.webkit.org/attachment.cgi?id=75102&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75102&action=review

> WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:272
> +	   for (var extension in baselines[platform]) {
> +	       if (!isFirstExtension) {

Should we sort the extensions too?

> WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:218
> +	       if platform not in all_test_baselines:
> +		   all_test_baselines[platform] = {}

Nit: You can use the oddly named setdefault here to save a lookup:
  platform_baselines = all_test_baselines.setdefault(platform, {})
  was_used_for_test = ...
  platform_baselines[baseline_extension] = was_used_for_test