[webkit-reviews] review denied: [Bug 50075] IndexedDB: Better errors for not yet implemented features : [Attachment 74888] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 50075: IndexedDB: Better errors for not yet implemented features
https://bugs.webkit.org/show_bug.cgi?id=50075

Attachment 74888: Patch
https://bugs.webkit.org/attachment.cgi?id=74888&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74888&action=review

> LayoutTests/storage/indexeddb/create-object-store-options.html:48
> +	   debug("db.createObjectStore('c', {autoIncrement: true});");

FIXME that this _should_ work..but not yet

> LayoutTests/storage/indexeddb/create-object-store-options.html:50
> +	   fail('createObjectStore with autoIncrement = true should throw');

testFailed

> LayoutTests/storage/indexeddb/objectstore-basics.html:146
> +    debug("Try to insert data with a Date key:");

FIXME

> LayoutTests/storage/indexeddb/objectstore-basics.html:160
> +    result.onerror = function () {};

This should print pass and then run the next part.