[webkit-reviews] review granted: [Bug 50088] Web Inspector: highlight diffs of revisions against base version. : [Attachment 74887] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 50088: Web Inspector: highlight diffs of revisions against base version.
https://bugs.webkit.org/show_bug.cgi?id=50088

Attachment 74887: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=74887&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74887&action=review

> WebCore/inspector/front-end/ResourcesPanel.js:372
> +	   if (resource.__initialRevision && resource.content && view
instanceof WebInspector.SourceView) {

Please rename __initialRevision to _baseRevision

> WebCore/inspector/front-end/ResourcesPanel.js:1109
> +	       this._resource.__initialRevision = revisionResource;

This field should be encapsulated into the resource. Please file a bug on this
and do it in a separate CL.