[webkit-reviews] review requested: [Bug 50083] [Gtk] ASSERT(d->m_response.isNull()) in contentSniffedCallback : [Attachment 74881] Fix for the bug

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has asked  for review:
Bug 50083: [Gtk] ASSERT(d->m_response.isNull()) in contentSniffedCallback
https://bugs.webkit.org/show_bug.cgi?id=50083

Attachment 74881: Fix for the bug
https://bugs.webkit.org/attachment.cgi?id=74881&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
This should be "the right thing". We should not emit the content-sniffed
callback if it was disabled for that particular SoupMessage. The problem is
that soup_message_disables_feature is not in the public API of SoupMessage.

My proposal would be to just apply the changes in ResourceHandleSoup.cpp (i.e.
do not connect to the "content-sniffed" signal) because:
   * it's correct anyway
   * it'll fix the bug
   * the invalid signal emission is located in the soup imported code, and
thus, when moved there the soup_message_disables_feature could be easily added
then (we can add that code as a comment)