[webkit-reviews] review denied: [Bug 49465] Enabling test expectations analyzer : [Attachment 74277] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 25 08:02:31 PST 2010
David Levin <levin at chromium.org> has denied imasaki at chromium.org's request for
review:
Bug 49465: Enabling test expectations analyzer
https://bugs.webkit.org/show_bug.cgi?id=49465
Attachment 74277: Patch
https://bugs.webkit.org/attachment.cgi?id=74277&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74277&action=review
> LayoutTests/ChangeLog:3
> + Reviewed by vrk
Don't fill in this line. Leave it as NOBODY(OOPS).
If you were to fill it in, you'd write out the full name of the person, not
part of their email addresss.
> LayoutTests/ChangeLog:5
> + change
What is this about?
> LayoutTests/ChangeLog:7
> + Enabling test expectations analyzer
This doesn't make sense to the outside observer (which I consider myself).
There is no enabling of anything in this bug only adding a bunch of BUG* to
various lines in test_expectations.
Also it is totally unclear what the objective is and why those BUG* are being
added.
Please concisely explain why you are adding this change to test_expectations
(mostly adding more BUG* to various lines and removing other BUG*).
> LayoutTests/platform/chromium/test_expectations.txt:2922
> +// BUG60845 : Adding the sleep may improves the stablility
two spaces after sleep
More information about the webkit-reviews
mailing list