[webkit-reviews] review granted: [Bug 50063] [v8] Web Inspector: display name of an object constructor as the object's type : [Attachment 74871] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 25 07:08:54 PST 2010
Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 50063: [v8] Web Inspector: display name of an object constructor as the
object's type
https://bugs.webkit.org/show_bug.cgi?id=50063
Attachment 74871: Patch
https://bugs.webkit.org/attachment.cgi?id=74871&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74871&action=review
Please do renaming prior to landing.
> WebCore/inspector/InjectedScriptHost.idl:41
> + [Custom] DOMObject constructorName(in DOMObject object);
internalConstructorName?
> WebCore/inspector/front-end/InjectedScript.js:431
> + if (result === "Object") {
If constructorName is Object, then we use constructor name?
More information about the webkit-reviews
mailing list