[webkit-reviews] review denied: [Bug 50075] IndexedDB: Better errors for not yet implemented features : [Attachment 74872] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 50075: IndexedDB: Better errors for not yet implemented features
https://bugs.webkit.org/show_bug.cgi?id=50075

Attachment 74872: Patch
https://bugs.webkit.org/attachment.cgi?id=74872&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74872&action=review

close

> LayoutTests/ChangeLog:11
> +	   Test that failing to supply a key when inserting data in an

Also test that supplying one when autoIncrement is set produces an error.

> LayoutTests/storage/indexeddb/objectstore-basics.html:152
> +	   testPassed("Exception thrown: " + err);

>From now on, let's do this instead:

code = e.code
shouldBe(code, THE_EXCEPTION)

This way when we change the codes, everything still works fine.  And it makes
the output less confusing in the mean time.

> WebCore/ChangeLog:8
> +	   In createObjectStore, make autoIncrement default (as per the spec).

remove

> WebCore/storage/IDBDatabase.cpp:68
> +    bool autoIncrement = true;

revert this.  the spec needs to be fixed instead

> WebCore/storage/IDBObjectStoreBackendImpl.cpp:211
> +    } else if (!key && objectStore->autoIncrement()) {
> +	  
callbacks->onError(IDBDatabaseError::create(IDBDatabaseException::DATA_ERR, "No
key supplied. Auto increment not currently supported."));

If autoIncrement is true and a key is supplied, it's an error..not something
where we should ignore the key.

Add a fixme to implement this for realz.