[webkit-reviews] review canceled: [Bug 48110] getBoundingClientRect: Do not truncate the coordinates to integers : [Attachment 74085] Fix and layout test

[bugzilla-daemon at webkit.org]

Cosmin Truta <ctruta at chromium.org> has canceled Cosmin Truta
<ctruta at chromium.org>'s request for review:
Bug 48110: getBoundingClientRect: Do not truncate the coordinates to integers
https://bugs.webkit.org/show_bug.cgi?id=48110

Attachment 74085: Fix and layout test
https://bugs.webkit.org/attachment.cgi?id=74085&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
> So why don't you change the expectations in the test file, so it says PASS?

I spent some time trying to figure out how to reconcile Chromium vs.
non-Chromium WebKit results, until (silly me) it eventually occurred to me that
the place to put font-dependent (therefore platform-dependent) coordinates is
the expectation file, not the source HTML.
So I added SKIP besides the usual PASS/FAIL and one of the tests, and I removed
shouldBe() calls altogether in the other one.

In general, IMO, the shouldBe calls should be placed (no pun intended) only
where there's a good reason to expect a certain number, or a certain formula.
Everything else should be checked via expectation files.