[webkit-reviews] review granted: [Bug 49605] Make WebPageProxy::decidePolicyForMIMEType a tad synchronous : [Attachment 74012] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 49605: Make WebPageProxy::decidePolicyForMIMEType a tad synchronous
https://bugs.webkit.org/show_bug.cgi?id=49605

Attachment 74012: Patch
https://bugs.webkit.org/attachment.cgi?id=74012&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74012&action=review

> WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:533
>  
> -   
webPage->send(Messages::WebPageProxy::DecidePolicyForMIMEType(m_frame->frameID(
), MIMEType, url, listenerID));
> +    bool receivedPolicyAction;
> +    uint64_t policyAction;
> +    uint64_t downloadID;
> +    if
(!webPage->sendSync(Messages::WebPageProxy::DecidePolicyForMIMEType(m_frame->fr
ameID(), MIMEType, url, listenerID),
Messages::WebPageProxy::DecidePolicyForMIMEType::Reply(receivedPolicyAction,
policyAction, downloadID)))
> +	   return;
> +
> +    if (receivedPolicyAction)
> +	   m_frame->didReceivePolicyDecision(listenerID,
static_cast<PolicyAction>(policyAction), downloadID);

I think this deserves a comment indicating why this needs to be sync for now
and how we may be able to mitigate this issue in the future (if that is
desired).