[webkit-reviews] review denied: [Bug 49576] jsc does not ignore shebang : [Attachment 73960] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 16 10:58:58 PST 2010


Geoffrey Garen <ggaren at apple.com> has denied John Tantalo
<john.tantalo at gmail.com>'s request for review:
Bug 49576: jsc does not ignore shebang
https://bugs.webkit.org/show_bug.cgi?id=49576

Attachment 73960: proposed patch
https://bugs.webkit.org/attachment.cgi?id=73960&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think you've made this change at the wrong level of abstraction. Accounting
for shebang in the lexer applies this Unix-only rule to all web pages and
operating systems.

I think a better fix would be for the jsc tool itself to strip out shebang
before evaluating a source file.


More information about the webkit-reviews mailing list