[webkit-reviews] review granted: [Bug 49586] Chrome DevTools: concatenate CSS files, do not link missing JS files in release mode. : [Attachment 73986] [PATCH] Addressed Mikhail's comments.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 49586: Chrome DevTools: concatenate CSS files, do not link missing JS files
in release mode.
https://bugs.webkit.org/show_bug.cgi?id=49586

Attachment 73986: [PATCH] Addressed Mikhail's comments.
https://bugs.webkit.org/attachment.cgi?id=73986&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73986&action=review

Please address the comments before landing.

> WebKit/chromium/Build/concatenate_css_files.py:2
> +# Copyright (c) 2009 The Chromium Authors. All rights reserved.

it's 2010 already:) and btw should we use a different license header like in
the other webkit files?

> WebKit/chromium/Build/concatenate_css_files.py:7
> +# using <script> tags in a given 'order.html' file.

did you mean using <link> tags?

> WebKit/chromium/Build/concatenate_css_files.py:60
> +    extractor.ordered_css_files.append('devTools.css')

should we have a comment explaining this stuff?

> WebKit/chromium/Build/concatenate_css_files.py:67
> +	   if (full_path is None):

nit: if not full_path:

> WebKit/chromium/Build/concatenate_js_files.py:2
> +# Copyright (c) 2009 The Chromium Authors. All rights reserved.

2009->2010

> WebKit/chromium/Build/concatenate_js_files.py:42
> +		       raise Exception('Ambiguous file %s: found in %s and %s'
%

I understand that these are build scripts but can we extract common
functionality into its own file?

> WebKit/chromium/Build/generate_devtools_html.py:2
> +# Copyright (c) 2009 The Chromium Authors. All rights reserved.

2009->2010