[webkit-reviews] review denied: [Bug 48986] [GTK] Some key-press events can't be handled by WebView : [Attachment 73981] Patch to fix the problem

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 48986: [GTK] Some key-press events can't be handled by WebView
https://bugs.webkit.org/show_bug.cgi?id=48986

Attachment 73981: Patch to fix the problem
https://bugs.webkit.org/attachment.cgi?id=73981&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73981&action=review

Thanks for making this fix!

> WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:141
> +static void popupMenuCallback(GtkWidget* widget, EditorClient* client)
> +{
> +    g_signal_stop_emission_by_name(widget, "popup-menu");
> +}
> +
> +static void showHelpCallback(GtkWidget* widget, EditorClient* client)
> +{
> +    g_signal_stop_emission_by_name(widget, "show-help");
> +}
> +

Since "client" is unused the variable name should be omitted from the argument
list. Isn't it possible to forward these signals to the WebView? I believe that
show-help at least is important for accessibility.