[webkit-reviews] review denied: [Bug 49497] getMIMEType(s)ForExtension should consult system mapping : [Attachment 73831] Proposed patch

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has denied Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 49497: getMIMEType(s)ForExtension should consult system mapping
https://bugs.webkit.org/show_bug.cgi?id=49497

Attachment 73831: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=73831&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73831&action=review

If the system-specific registry has priority, shouldn't it be consulted first
in getMediaMIMETypesForExtension()?

> WebCore/platform/MIMETypeRegistry.cpp:364
> +	   typeList.append(*mediaMIMETypeMap().get(ext));

Would it be faster to put the result of mediaMIMETypeMap().get() in a local
variable and then test it for null, rather than calling both contains() and
get()? (I realize this pattern already existed in this function.)