[webkit-reviews] review denied: [Bug 49532] [GTK] Use gdk_pixbuf_get_from_surface() when available : [Attachment 73885] Patch to use gdk_pixbuf_get_from_surface()

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 49532: [GTK] Use gdk_pixbuf_get_from_surface() when available
https://bugs.webkit.org/show_bug.cgi?id=49532

Attachment 73885: Patch to use gdk_pixbuf_get_from_surface()
https://bugs.webkit.org/attachment.cgi?id=73885&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73885&action=review

> WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp:37
> +#ifndef GTK_API_VERSION_2
> +GdkPixbuf* cairoImageSurfaceToGdkPixbuf(cairo_surface_t* surface)
> +{
> +    return gdk_pixbuf_get_from_surface(surface, 0, 0,
> +					 
cairo_image_surface_get_width(surface),
> +					 
cairo_image_surface_get_height(surface));

Is this new method used anywhere? Ideally a code change like this should be
accompanied by a corresponding change in functionality somewhere. If there is
some hidden functionality change it should be outlined in the ChangeLog.