[webkit-reviews] review denied: [Bug 49106] Include the FrameView widget of a RenderWidget in the accessibility tree. : [Attachment 73803] Proposed patch.

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied chris.guillory at google.com's
request for review:
Bug 49106: Include the FrameView widget of a RenderWidget in the accessibility
tree.
https://bugs.webkit.org/show_bug.cgi?id=49106

Attachment 73803: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=73803&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73803&action=review

> WebCore/accessibility/AccessibilityRenderObject.cpp:416
> +    // On the mac port this parent logic is in AccessibleObjectWrapper.mm.

not the right name of the file.

> WebCore/accessibility/AccessibilityRenderObject.cpp:419
>      }

one line else if shouldn't have { }

> WebCore/accessibility/AccessibilityRenderObject.cpp:1879
> +#endif

shouldn't this go into accessibilityIgnoreAttachment() which can be customized
per platform?

> WebCore/accessibility/AccessibilityRenderObject.cpp:3382
> +    // for RenderWidget, add frame's content renderer if the widget is a
FramwView.

spelling

> WebCore/accessibility/AccessibilityRenderObject.cpp:3383
> +    // on the mac port this children logic is in AccessibleObjectWrapper.mm.


the file name is AccessibilityObjectWrapper.mm.
All comments should be full sentences