[webkit-reviews] review granted: [Bug 48506] Move DeviceOrientationClientMock from LayoutTestController to WebViewHost : [Attachment 73904] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 48506: Move DeviceOrientationClientMock from LayoutTestController to
WebViewHost
https://bugs.webkit.org/show_bug.cgi?id=48506

Attachment 73904: Patch
https://bugs.webkit.org/attachment.cgi?id=73904&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73904&action=review

r=me

> WebCore/platform/mock/DeviceOrientationClientMock.cpp:43
> +    ASSERT(controller);

It's probably better to keep the m_controler check after

> WebCore/platform/mock/DeviceOrientationClientMock.cpp:-43
> -    ASSERT(m_controller);

I think it's better to leave this one.

> WebKitTools/ChangeLog:9
> +	   https://bugs.webkit.org/show_bug.cgi?id=48506

"""
Reviewed by

Title
this url

description
"""

Also describe why it's a design constraint.