[webkit-reviews] review denied: [Bug 49350] bufferData/bufferSubData should not crash with null data input : [Attachment 73557] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 11 13:46:34 PST 2010


Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 49350: bufferData/bufferSubData should not crash with null data input
https://bugs.webkit.org/show_bug.cgi?id=49350

Attachment 73557: patch
https://bugs.webkit.org/attachment.cgi?id=73557&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Unfortunately the spec is badly written in this area, in particular for
bufferData. I don't think that making the call a no-op is the right thing to
do. I've just committed an update to the spec requiring that INVALID_VALUE is
raised if bufferData is called with a null ArrayBuffer or ArrayBufferView.
Could you please update the code and test? Thanks.


More information about the webkit-reviews mailing list