[webkit-reviews] review granted: [Bug 49132] [GTK] Use __attribute__((constructor)) to call webkit_init at library init time : [Attachment 73613] Patch with Fridrich's suggestions

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 49132: [GTK] Use __attribute__((constructor)) to call webkit_init at
library init time
https://bugs.webkit.org/show_bug.cgi?id=49132

Attachment 73613: Patch with Fridrich's suggestions
https://bugs.webkit.org/attachment.cgi?id=73613&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73613&action=review

You guys are great =).

> WebCore/platform/graphics/gtk/ImageGtk.cpp:46
> +    if (!module) {
> +	   GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS |
GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT,
> +			     static_cast<LPCSTR>(getWebKitDataDirectory),
&module);
> +    }

Should not have the bracers here.