[webkit-reviews] review denied: [Bug 49333] simplify png decoding loop : [Attachment 73520] simpler png loop

[bugzilla-daemon at webkit.org]

Peter Kasting <pkasting at google.com> has denied Pascal Massimino
<pascal.massimino at gmail.com>'s request for review:
Bug 49333: simplify png decoding loop
https://bugs.webkit.org/show_bug.cgi?id=49333

Attachment 73520: simpler png loop
https://bugs.webkit.org/attachment.cgi?id=73520&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This isn't quite right.  If row 0 has alpha and row 1 does not, you'll
setHasAlpha(true) on the first row and (false) on the second.

Instead you should probably do:

if (nonTrivialAlpha)
    buffer.setHasAlpha(true);

...at the end.

It would be good to add a pixel test with a png that exercises this particular
case.