[webkit-reviews] review granted: [Bug 49285] [Chromium/DRT] Make EventSendingController send complete touch events. : [Attachment 73505] p1 for 49285

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 49285: [Chromium/DRT] Make EventSendingController send complete touch
events.
https://bugs.webkit.org/show_bug.cgi?id=49285

Attachment 73505: p1 for 49285
https://bugs.webkit.org/attachment.cgi?id=73505&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73505&action=review

Patch looks good, but please fix/remove the comment before landing.

> WebKitTools/DumpRenderTree/chromium/EventSender.cpp:878
> +    // Force a layout here just to make sure every position has been
> +    // determined before we send events (as well as all the other methods
> +    // that send an event do).

This comment doesn't seem very helpful, I'd just leave it out.	It's also not
entirely accurate from what I can tell (it won't change the position argument
passed on this event).