[webkit-reviews] review granted: [Bug 48877] [chromium] WebGL isFoo() tests fail in command buffer : [Attachment 73442] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 48877: [chromium] WebGL isFoo() tests fail in command buffer
https://bugs.webkit.org/show_bug.cgi?id=48877

Attachment 73442: Patch
https://bugs.webkit.org/attachment.cgi?id=73442&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Good catch and looks good overall. Per Brian Paul's comments on the Mesa bug
you filed, if real drivers have incorrect behavior (and it seems that some do)
then we may have a problem. In this case we would need to make the test more
conservative, and only call isBuffer, isFramebuffer, etc. after the first bind
of the object.

Please add the test to the Khronos repo if you haven't already.