[webkit-reviews] review granted: [Bug 49326] print-vse-failure-logs prints logs in an unhelpful order : [Attachment 73504] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 49326: print-vse-failure-logs prints logs in an unhelpful order
https://bugs.webkit.org/show_bug.cgi?id=49326

Attachment 73504: Patch
https://bugs.webkit.org/attachment.cgi?id=73504&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73504&action=review

SOOO EXCITED!

We still need to test this stuff.

> WebKitTools/Scripts/print-vse-failure-logs:57
> +    def _build_order(self):

Might be helpful to explain what this returns.

> WebKitTools/Scripts/print-vse-failure-logs:58
> +	   script_path = os.path.join(self._scripts_directory(),
"print-msvc-project-dependencies")

I didn't know this existed!

> WebKitTools/Scripts/print-vse-failure-logs:76
> +	       return (index, project_name)

I didn't realize a tuple could be a sort key.