[webkit-reviews] review requested: [Bug 23432] window.open scripts do not trigger newWindowDelegate callback. : [Attachment 73417] [PATCH 3/4] Don't duplicate code from FrameTree::find()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 9 14:22:39 PST 2010
Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> has asked for review:
Bug 23432: window.open scripts do not trigger newWindowDelegate callback.
https://bugs.webkit.org/show_bug.cgi?id=23432
Attachment 73417: [PATCH 3/4] Don't duplicate code from FrameTree::find()
https://bugs.webkit.org/attachment.cgi?id=73417&action=review
------- Additional Comments from Nicolas Dufresne
<nicolas.dufresne at collabora.co.uk>
In JSDOMWindow::open() we duplicate some of the code from
FrameTree::find(). This patch also removes one call to FrameTree::find().
This code cleanup is attached to this bug since it ensure that createWindow
is actually called to create new window, reducing side effect risk.
More information about the webkit-reviews
mailing list