[webkit-reviews] review requested: [Bug 23432] window.open scripts do not trigger newWindowDelegate callback. : [Attachment 73418] [PATCH 4/4] Trigger newWindowDelegate when window.open() is called

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 9 14:23:11 PST 2010


Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> has asked  for review:
Bug 23432: window.open scripts do not trigger newWindowDelegate callback.
https://bugs.webkit.org/show_bug.cgi?id=23432

Attachment 73418: [PATCH 4/4] Trigger newWindowDelegate when window.open() is
called
https://bugs.webkit.org/attachment.cgi?id=73418&action=review

------- Additional Comments from Nicolas Dufresne
<nicolas.dufresne at collabora.co.uk>
This is a bit tricky since newWindowDelegate() is normally triggered before
creating the actual window. But since window.open() returns a window, we have
no choice but to create it. In this patch, we play with the window visibility,
creating the window and launching the newWindowDelegate() through
changeLocation() and a special optional parameter. The result is that the
window will only be showed if the policy is accepted, and will be closed


More information about the webkit-reviews mailing list