[webkit-reviews] review denied: [Bug 49115] Add custom bindings for AudioContext : [Attachment 73147] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 49115: Add custom bindings for AudioContext
https://bugs.webkit.org/show_bug.cgi?id=49115

Attachment 73147: Patch
https://bugs.webkit.org/attachment.cgi?id=73147&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73147&action=review

> WebCore/bindings/v8/custom/V8AudioContextCustom.cpp:43
> +	   return throwError("AudioContext constructor associated frame is
unavailable", V8Proxy::ReferenceError);

Why is there a difference between the JS and V8 bindings in whether these
values are null-checked at run time? Please make the two bindings work
identically. If this isn't supposed to happen then make it an ASSERT.