[webkit-reviews] review denied: [Bug 34660] audio engine: add audio resources abstraction : [Attachment 73144] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 34660: audio engine: add audio resources abstraction
https://bugs.webkit.org/show_bug.cgi?id=34660

Attachment 73144: Patch
https://bugs.webkit.org/attachment.cgi?id=73144&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73144&action=review

The code basically looks fine. r- for the license header issue as well as a
couple of other minor issues.

> WebCore/platform/audio/mac/AudioBusMac.mm:15
> + *	  from this software without specific prior written permission.

Wrong license header.

> WebCore/platform/audio/mac/AudioBusMac.mm:40
> + at interface WebCoreBundleClass : NSObject

I think it would be safer to name this temporary class something audio-specific
like WebCoreAudioBundleClass.

> WebCore/platform/audio/mac/AudioBusMac.mm:68
> +} // WebCore

// namespace WebCore