[webkit-reviews] review denied: [Bug 49069] WebViewHost::reset() uses placement new. : [Attachment 73064] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 49069: WebViewHost::reset() uses placement new.
https://bugs.webkit.org/show_bug.cgi?id=49069

Attachment 73064: Patch
https://bugs.webkit.org/attachment.cgi?id=73064&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73064&action=review

> WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp:1111
> +    m_policyDelegateEnabled = false;
> +    m_policyDelegateIsPermissive = false;
> +    m_policyDelegateShouldNotifyDone = false;
> +    m_topLoadingFrame = 0;
> +    m_pageId = -1;
> +    m_lastPageIdUpdated = -1;
> +    m_hasWindow = false;
> +    m_inModalLoop = false;
> +    m_smartInsertDeleteEnabled = true;
> +#if OS(WINDOWS)
> +    m_selectTrailingWhitespaceEnabled = true;
> +#else
> +    m_selectTrailingWhitespaceEnabled = false;
> +#endif
> +    m_blocksRedirects = false;
> +    m_requestReturnNull = false;
> +    m_isPainting = false;
> +    m_canvas.clear();

We had better reset the followings too:
m_pendingExtraData
m_resourceIdentifierMap
m_currentCursor
m_windowRect
m_clearHeaders
m_editCommandName
m_editCommandvalue
m_paintRect

Some of them don't need to be reset.  But we should be consistent.