[webkit-reviews] review denied: [Bug 36171] [Qt] QtWebKit doesn't support NPAPI for DirectFB : [Attachment 73107] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Anders Bakken
<agbakken at gmail.com>'s request for review:
Bug 36171: [Qt] QtWebKit doesn't support NPAPI for DirectFB
https://bugs.webkit.org/show_bug.cgi?id=36171

Attachment 73107: Patch
https://bugs.webkit.org/attachment.cgi?id=73107&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73107&action=review

Basically, I would like to see all X11 related code guard by x11 defines.

> WebCore/bridge/npapi.h:92
> +#if defined(XP_UNIX) && !defined(XP_DFB)

I'd prefer if you did:

#if defined(XP_UNIX) && defined(X_PROTOCOL)

So you'd be including X-related stuff when it is X.

> WebCore/bridge/npapi.h:246
> +#if defined(XP_UNIX) && !defined(XP_DFB)

Ditto.

> WebCore/bridge/npruntime_internal.h:32
> +#if defined XP_UNIX && !defined(XP_DFB)

Ditto

> WebCore/plugins/PluginView.cpp:373
> +#if defined(XP_X11) && !defined(XP_DFB)

here you could do:

#if defined(XP_X11_ && PLATFORM(X11)