[webkit-reviews] review denied: [Bug 25459] Regression(?): tabs in RTL erroneously overflows : [Attachment 73122] patch w/ layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 5 15:00:49 PDT 2010


Dave Hyatt <hyatt at apple.com> has denied Xiaomei Ji <xji at chromium.org>'s request
for review:
Bug 25459: Regression(?): tabs in RTL erroneously overflows
https://bugs.webkit.org/show_bug.cgi?id=25459

Attachment 73122: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=73122&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I think this idea is fine for RTL, but the patch (unless I'm mistaken) will
break LTR.  In the case where the logicalLeft of the root box in LTR doesn't
happen to match the left content edge of the containing block (e.g., because of
a left float), then this will make the tabs behave differently on the narrower
LTR lines.


More information about the webkit-reviews mailing list